On Wed, 25 Jun 2025 09:24:21 GMT, Alexey Ivanov <aiva...@openjdk.org> wrote:
> > Rewriting the test, if needed, could be done as part of new issue but this > > one fixes the issue and let manual testing team run the test in all L&F > > Why not now? We have a bug in the test, your fix doesn't fix the fundamental > problem with the test, but rather tweaks the test so that the problem isn't > visible any more. > > > > I commented out the line UIManager.setLookAndFeel(save), the Windows menu > > > looks good but clicking the Metal menu now throws NPE: > > > > > > I couldn't reproduce this problem with the current PR..What L&F you started > > the test with? I tested the test with Metal/Windows/Nimbus from the > > commandline and couldn't find any issue. > > Nimbus, as specified in the command line in the bug description: > > `-vmoption:-Dswing.defaultlaf=javax.swing.plaf.nimbus.NimbusLookAndFeel` > > You can't reproduce NPE if there's a call to > `SwingUtilities.updateComponentTreeUI(frame)` because it updates the L&F of > the top-level menu items, those that are on the menu bar. I dont want to do it as I already told before..Its the same strategy used in other recently opensourced tests I mentioned before where `SwingUtilities.updateComponentTreeUI(frame)` is used ... ------------- PR Comment: https://git.openjdk.org/jdk/pull/25907#issuecomment-3004106471
