On Wed, 25 Jun 2025 06:52:15 GMT, Prasanta Sadhukhan <psadhuk...@openjdk.org> wrote:
>> Ctrl+Shift+Down/Up does extend row selection down or up in Aqua L&F as it >> does in native tree view in Finder. >> Fixed the keybindings. > > Prasanta Sadhukhan has updated the pull request incrementally with one > additional commit since the last revision: > > Correct bugid I mentioned in your other PR that I can test this natively with a bunch of folders in Finder when viewing under `List View`. One note is that natively on macOS in Finder, there is a pinging noise for each CTRL+SHIFT+(UP/DOWN). This is in contrast to just SHIFT+(UP/DOWN) which does the same thing but without the pinging. Do you have any idea why this is? Test looks good when testing myself. test/jdk/javax/swing/JTree/TestTreeRowSelection.java line 29: > 27: * @requires (os.family == "mac") > 28: * @bug 8360462 > 29: * @summary Verifies ctrl+shift+down slects next row in AquaL&F Suggestion: * @summary Verifies ctrl+shift+down selects next row in Aqua L&F ------------- PR Review: https://git.openjdk.org/jdk/pull/25966#pullrequestreview-2958810156 PR Review Comment: https://git.openjdk.org/jdk/pull/25966#discussion_r2167095570
