On Wed, 23 Jul 2025 21:07:21 GMT, Damon Nguyen <[email protected]> wrote:
>> Prasanta Sadhukhan has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Test update
>
> src/java.desktop/share/classes/javax/swing/JPopupMenu.java line 1430:
>
>> 1428: indexCounter++;
>> 1429: }
>> 1430: if(indexCounter < maxCounter && values.elementAt(indexCounter).
>
> Suggestion:
>
> if (indexCounter < maxCounter && values.elementAt(indexCounter).
the formatting is consistent with the previous 2 checks so I didn't change, so
either I have to change the previous lines formatting too since it will look
odd if we change mine and not the previous so I kept it as it is like previous
check.
> test/jdk/javax/swing/JPopupMenu/TestPopupInvoker.java line 86:
>
>> 84: });
>> 85: if (isVisible) {
>> 86: throw new RuntimeException("poup is visible after
>> component is removed");
>
> Suggestion:
>
> throw new RuntimeException("popup is visible after component
> is removed");
fixed
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/26407#discussion_r2227173524
PR Review Comment: https://git.openjdk.org/jdk/pull/26407#discussion_r2227176399
