On Fri, 25 Jul 2025 18:07:13 GMT, Phil Race <p...@openjdk.org> wrote:

>> Alisen Chung has updated the pull request incrementally with one additional 
>> commit since the last revision:
>> 
>>   remove static from step delay/length fields
>
> test/jdk/lib/client/ExtendedRobot.java line 253:
> 
>> 251:      * @see     #delay(int)
>> 252:      */
>> 253:      public void glide(int srcX, int srcY, int destX, int destY, int 
>> stepLength, int speed) {
> 
> I hadn't noticed that this over-ride is both removed here and not added to 
> Robot.
> If this were available, then perhaps those setters and getters for the 
> current values aren't needed !
> What was the reason for not including it ? No one ever used it or something 
> else ?

I actually removed this when I added the setters/getters since I thought it was 
redundant. Do you think having this override is better than having the 
setters/getters? I can revert the change

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22044#discussion_r2237236118

Reply via email to