On Thu, 31 Jul 2025 05:37:59 GMT, Ravi Gupta <rgu...@openjdk.org> wrote:
>> Test test/jdk/java/awt/Mouse/MouseModifiersUnitTest/ExtraButtonDrag.java
>> left debris on system whenever fails its required frame.dispose() in finally
>> block.
>>
>>
>> finally {
>> EventQueue.invokeAndWait(ExtraButtonDrag::disposeFrame);
>> }
>> public static void disposeFrame() {
>> if (frame != null) {
>> frame.dispose();
>> frame = null;
>> }
>> }
>
> Ravi Gupta has updated the pull request incrementally with one additional
> commit since the last revision:
>
> 8361067: Review Comments fix
Looks good to me now. Just a minor correction can be done in summary.
test/jdk/java/awt/Mouse/MouseModifiersUnitTest/ExtraButtonDrag.java line 28:
> 26: * @key headful
> 27: * @bug 6315717
> 28: * @summary verifies that drag events are coming for every button if the
> property is set to true
Summary can be re-phrased to --
Verifies that mouse drag events received for every button if the property is
set to true
-------------
Marked as reviewed by abhiscxk (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/26043#pullrequestreview-3074866511
PR Review Comment: https://git.openjdk.org/jdk/pull/26043#discussion_r2245007756
