On Fri, 1 Aug 2025 04:09:23 GMT, Prasanta Sadhukhan <psadhuk...@openjdk.org>
wrote:
>> Phil Race has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 8363889
>
> src/java.desktop/share/classes/sun/print/PrintJob2D.java line 35:
>
>> 33: import java.awt.JobAttributes.*;
>> 34: import java.awt.PageAttributes;
>> 35: import java.awt.PageAttributes.*;
>
> wildcard..probably it should be removed as it is used in Delegate class
yes, they aren't used in this class. I'll remove them.
> src/java.desktop/share/classes/sun/print/PrintJob2D.java line 115:
>
>> 113: }
>> 114:
>> 115: private static class PrintJobDisposerRecord implements
>> DisposerRecord {
>
> should we also make it a final class?
I don't see that it matters.
> src/java.desktop/share/classes/sun/print/PrintJobDelegate.java line 2:
>
>> 1: /*
>> 2: * Copyright (c) 2000, 2025, Oracle and/or its affiliates. All rights
>> reserved.
>
> should it be 2000? its a new class but its content is from 2000!!
Not sure what you are saying.
You seem to be saying it should say 2000 .. but it does .. and yes it should ...
The filename doesn't matter the material is what matters.
> src/java.desktop/share/classes/sun/print/PrintJobDelegate.java line 36:
>
>> 34: import java.awt.JobAttributes.*;
>> 35: import java.awt.PageAttributes;
>> 36: import java.awt.PageAttributes.*;
>
> wildcard
Here I'm not 'cleaning up' anything. I just moved it.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/26432#discussion_r2248894928
PR Review Comment: https://git.openjdk.org/jdk/pull/26432#discussion_r2248896184
PR Review Comment: https://git.openjdk.org/jdk/pull/26432#discussion_r2248898997
PR Review Comment: https://git.openjdk.org/jdk/pull/26432#discussion_r2248899448
