On Thu, 24 Jul 2025 15:24:52 GMT, Damon Nguyen <dngu...@openjdk.org> wrote:

> > > > What exactly is the failure thrown in Nimbus L&F? JBS says 
> > > > `PassFailJFrame.forceFail `is called From my running it seems the 
> > > > failure is `"java.lang.RuntimeException: leading cell is not aligned"` 
> > > > It can be a genuine issue for Nimbus since it behaves ok for other L&F..
> > > 
> > > 
> > > I ran into the same issue when I previously checked this. I can submit a 
> > > Nimbus issue afterwards if needed. Wanted to handle the test here first.
> > 
> > 
> > But you are handling the test failure by just omitting Nimbus run, which is 
> > not the way to go about it in my opinion..
> 
> I have gone through the changes again and in converting the test, nothing 
> Nimbus specific was touched. I can't re-run the old test due to its reliance 
> on Applet. When converting the test, I don't believe anyone, including 
> myself, tested it on Nimbus since the test doesn't cycle thru all LAFs. The 
> error in Nimbus only seems to be due to `cellRect` sizing not matching 
> `visRect`. I don't see how that's related to the changes in this test, and 
> rather may be a Nimbus issue.

That's what I was saying that if it's a Nimbus issue it will not be alright to 
discard Nimbus testing from the test as it can be a product bug in Nimbus and 
we can use this regression test to fix that issue, so as a positive side no 
need to write a new regression test and maybe the bug summary can be changed to 
show it's failing in Nimbus with "java.lang.RuntimeException: leading cell is 
not aligned"

-------------

PR Comment: https://git.openjdk.org/jdk/pull/26165#issuecomment-3142098273

Reply via email to