On Mon, 4 Aug 2025 09:48:36 GMT, Khalid Boulanouare <d...@openjdk.org> wrote:
>> Many Mixing tests failed because the work around click lands on the
>> minimizing area in the window control and causes the tests to fail.
>>
>> This fix changes the width of base frames which allows most of tests to pass.
>
> Khalid Boulanouare has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Removes wildcard imports
test/jdk/java/awt/Mixing/AWT_Mixing/GlassPaneOverlappingTestBase.java line 138:
> 136: FocusManager.getCurrentManager()
> 137: .getFocusOwner();
> 138: if (focusOwner == f) {
Guess you should be checking these before calling `requestFocusInWindow` as
there's no point in calling `requestFocusInWindow` if current focusOwner is f?
test/jdk/java/awt/Mixing/AWT_Mixing/GlassPaneOverlappingTestBase.java line 154:
> 152: lLoc.translate(1, testedComponent.getPreferredSize().height
> + 1);
> 153: try {
> 154: boolean await = latch.await(50, TimeUnit.MILLISECONDS);
50 ms is enough? guess you can go upto 1sec!!
will it make the other failed tests pass if we increase this timeout?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/25971#discussion_r2256096136
PR Review Comment: https://git.openjdk.org/jdk/pull/25971#discussion_r2256099509
