> Remove finalize() from WInputMethod.java - it is used to free a native id. > Also the reason dispose() didn't free it seems no longer relevant. > Although I did see (when instrumenting) that dispose() was called when I > disposed() the Frame referencing the IM, > I don't know if I can be sure that is always done. So safest to add the > Disposer in case it isn't.
Phil Race has updated the pull request incrementally with one additional commit since the last revision: 8365180 ------------- Changes: - all: https://git.openjdk.org/jdk/pull/26706/files - new: https://git.openjdk.org/jdk/pull/26706/files/fc422aa0..3c8c9cb4 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=26706&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=26706&range=00-01 Stats: 1 line in 1 file changed: 1 ins; 0 del; 0 mod Patch: https://git.openjdk.org/jdk/pull/26706.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/26706/head:pull/26706 PR: https://git.openjdk.org/jdk/pull/26706