On Fri, 18 Jul 2025 13:19:10 GMT, Christian Heilmann <d...@openjdk.org> wrote:
>> This PR fixes a bug that caused no or the wrong set of pages to be printed >> when using page ranges on macOS. >> >> The main fix is to change the 'location' value of the returned NSRange from >> the knowsPageRange method to 1 in the native class PrinterView.m. > > Christian Heilmann has updated the pull request with a new target base due to > a merge or a rebase. The incremental webrev excludes the unrelated changes > brought in by the merge/rebase. The pull request contains five additional > commits since the last revision: > > - 8297191 fixed printing page range for e.g. page 2 to 2 on macOS > - 8297191 fixed printing page range for e.g. page 2 to 2 on macOS > - Merge branch 'master' of https://github.com/openjdk/jdk into pr/11266 > - Merge branch 'master' into pr/11266 > - 8297191 fixed printing page range for e.g. page 2 to 2 on macOS This needs a test that people can run that shows "bad before fix, good afterwards". Either an existing jtreg test tagged in the PR with this bug id, or a new test if none covers it. And a comment about what tests have been run to show nothing is *broken* by this change would be good too. ------------- PR Comment: https://git.openjdk.org/jdk/pull/11266#issuecomment-3204268589
