On Fri, 22 Aug 2025 07:21:58 GMT, Tejesh R <t...@openjdk.org> wrote:
>> ScientificWare has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 25 commits:
>>
>> - Merge master
>> - JDK-8314731 : Remove all indentations accidentally introduced by the
>> previous commit.
>> - Merge master
>> - Merge master
>> - jdk-8314731 : FormView Alt Support.
>>
>> FormView.java :
>> - revert ALL unrelated changing to formatting.
>>
>> bug8314731.java :
>> - Fix the test description.
>> - Change where the user interface is created.
>> - Add a finall block to be sure the Frame is disposed.
>> - Replace "testPassed" with "testFailed".
>> - Merge master
>> - Replaces this title with "alt attribute test in HTML image type input".
>>
>> Moves this test to /jdk/test/jdk/javax/swing/text/html.
>> - bug8314731.java : Corrects the CopyRight date.
>> - FormView.java :
>> Removes a whitespace
>>
>> bug8314731.java :
>> Adds a newline at end of file.
>> - getMaximumSpan(int axis) method
>> doc -> Not used
>>
>> mouseReleased(MouseEvent evt) method
>> elem and hdoc -> not used
>> return -> could be removed, method returns void
>>
>> loadElementDataIntoBuffer(Element elem, StringBuilder buffer) method
>> value != null -> name can't be null at this point
>>
>> getInputElementData(AttributeSet attr) method
>> value = null -> Already set at null
>> - ... and 15 more: https://git.openjdk.org/jdk/compare/69e664de...9b423808
>
> test/jdk/javax/swing/text/html/bug8314731.java line 35:
>
>> 33: import java.awt.Container;
>> 34: import java.awt.Dimension;
>> 35: import java.lang.reflect.InvocationTargetException;
>
> Can be removed.
Remove `InvocationTargetException` from imports.
> test/jdk/javax/swing/text/html/bug8314731.java line 68:
>
>> 66: SwingUtilities.invokeAndWait(new Runnable() {
>> 67: public void run() {
>> 68: jf.dispose();
>
> Check if `jf` is not `null ` and then dispose
And use a lambda expression instead of explicit anonymous `Runnable`.
> Extra blank line is missing.
No, it's not missing. If it were, GitHub would've shown a warning, “No line
break in the end of file.” (Or similar.)
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/15319#discussion_r2298135091
PR Review Comment: https://git.openjdk.org/jdk/pull/15319#discussion_r2298095594
PR Review Comment: https://git.openjdk.org/jdk/pull/15319#discussion_r2298087703
