On Fri, 22 Aug 2025 17:39:10 GMT, Phil Race <p...@openjdk.org> wrote:
> Some text describing the Beans.instantiate lookup process existed only on the
> method that used the now removed AppletInitializer.
> Since there are two other Beans.instantiate methods, we need to move that
> text to the remaining methods.
>
> Note that one of the methods is also deprecated for removal, so it seems
> prudent to add it to both so that when the next to be removed method is gone,
> this problem doesn't recur.
>
> This is a doc. only change. The CSR is ready for review.
I see you just restoring the relevant portions of the existing javadoc for a
removed method. Marking up can be postponed to a later time, if at all.
src/java.desktop/share/classes/java/beans/Beans.java line 71:
> 69: * <p>
> 70: * The given name can indicate either a serialized object or a class.
> 71: * We first try to treat the beanName as a serialized object
Suggestion:
* We first try to treat the {@code beanName} as a serialized object
Should this be marked up as it refers the parameter name? Also, in other
instances.
src/java.desktop/share/classes/java/beans/Beans.java line 78:
> 76: * We then try to load a serialized object from that resource.
> 77: * <p>
> 78: * For example, given a beanName of "x.y", Beans.instantiate would
> first
Suggestion:
* For example, given a beanName of "x.y", {@code Beans.instantiate} would
first
Method names should be marked up.
-------------
Marked as reviewed by aivanov (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/26905#pullrequestreview-3152868058
PR Review Comment: https://git.openjdk.org/jdk/pull/26905#discussion_r2299017246
PR Review Comment: https://git.openjdk.org/jdk/pull/26905#discussion_r2299021839
