On Mon, 25 Aug 2025 10:15:04 GMT, Alexey Ivanov <aiva...@openjdk.org> wrote:
>> Damon Nguyen has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - Fix correcting character limit to undo all changes and leave file
>> untouched.
>> - Convert test to auto. Revert TextArea test changes
>
> test/jdk/java/awt/List/MouseDraggedOriginatedByScrollBarTest.java line 58:
>
>> 56: System.out.println("The test is XAWT-only.");
>> 57: return;
>> 58: }
>
> Use `@requires os.family == "linux"` to avoid starting the test on other OS.
>
> This check can then be removed.
Updated. Do I have to differentiate between X11 and Wayland though?
> test/jdk/java/awt/List/MouseDraggedOriginatedByScrollBarTest.java line 66:
>
>> 64: if (frame != null) {
>> 65: EventQueue.invokeAndWait(() -> frame.dispose());
>> 66: }
>
> Let's be consistent:
> Suggestion:
>
> EventQueue.invokeAndWait(() -> {
> if (frame != null) {
> frame.dispose();
> }
> });
Thanks! Updated.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/26636#discussion_r2302295748
PR Review Comment: https://git.openjdk.org/jdk/pull/26636#discussion_r2302295943
