On Fri, 29 Aug 2025 00:14:09 GMT, Phil Race <p...@openjdk.org> wrote:

> > REVIEWER NOTE: Please check the empty-string TextLayout behavior documented 
> > in TextLayoutConstructorTest carefully; a badly-behaving empty TextLayout 
> > is probably worse than a TextLayout which doesn't allow empty strings...
> 
> I assume you mean are the "expected" behaviours you assigned to all the 
> methods of such a constructed TextLayout reasonable behaviours ?

That's right; about half of the `TextLayout` public API surface area is new to 
me, so although I was very careful to try to make sure that the behaviors all 
made sense, I'll feel more comfortable once this part has been checked 
carefully.

> please create a CSR

No problem, here it is: https://bugs.openjdk.org/browse/JDK-8366563

-------------

PR Comment: https://git.openjdk.org/jdk/pull/26947#issuecomment-3242636667

Reply via email to