On Thu, 4 Sep 2025 10:57:21 GMT, Alexey Ivanov <aiva...@openjdk.org> wrote:
>> Khalid Boulanouare has updated the pull request with a new target base due >> to a merge or a rebase. The incremental webrev excludes the unrelated >> changes brought in by the merge/rebase. The pull request contains 46 >> additional commits since the last revision: >> >> - Merge branch 'openjdk:master' into jdk-8158801 >> - Disposes frame at the end of testing. >> - Moves latch logic inside ancestor frame block >> - Merge branch 'openjdk:master' into jdk-8158801 >> - Disposes frames after each AWT component test >> - Removes redundant code for centring frames >> - Merge branch 'openjdk:master' into jdk-8158801 >> - Merge branch 'openjdk:master' into jdk-8158801 >> - Centers missed frames in the middle of screen >> - Uses KeyboardFocusManager instead of FocusManager >> - ... and 36 more: https://git.openjdk.org/jdk/compare/d2fe5bd2...a62416a9 > > test/jdk/java/awt/Mixing/AWT_Mixing/GlassPaneOverlappingTestBase.java line > 145: > >> 143: } else { >> 144: f.requestFocusInWindow(); >> 145: } > > Is it possible to add the listener earlier to ensure the latch is released in > the focus listener? @aivanov-jdk as you have suggested, the focus owner and the latch are not needed because the GlassPaneOverlappingTestBase is using only one frame. I will refactor the code based on this. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/25971#discussion_r2322081059
