> There are several major issues with the test: > > 1. The `frameExited` variable is set to true when the mouse pointer exits the > frame. The test does not expect this to happen with the first mouse click on > the `choice` when the mouse pointer is already over the test frame (frame > mouseExited - > choice mouseEntered). A reset for the frameExited was added. > 2. The test does not wait for the frame to appear after the call to > `setVisible()`, so the test can start operating not on a fully visible window > (e.g. one with an appearance animation). A delay has been added. > 3. In macOS, the direction of rotation of the mouse wheel is different, which > was not taken into account. > > Testing looks good.
Alexander Zvegintsev has updated the pull request incrementally with one additional commit since the last revision: review comments ------------- Changes: - all: https://git.openjdk.org/jdk/pull/27161/files - new: https://git.openjdk.org/jdk/pull/27161/files/e6d3846f..f7c9bc09 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=27161&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=27161&range=00-01 Stats: 11 lines in 1 file changed: 1 ins; 1 del; 9 mod Patch: https://git.openjdk.org/jdk/pull/27161.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/27161/head:pull/27161 PR: https://git.openjdk.org/jdk/pull/27161