On Fri, 26 Sep 2025 18:54:03 GMT, Phil Race <[email protected]> wrote:
> > You can use str.isEmpty() here.
>
> I was actually going for consistency with all of the other optimizations of
> this type, which all use a length check. I can change it to `isEmpty` if you
> feel strongly about it, though.
>
Hi, you replaced this strange `''".equals` check ; is this because it looks
not nice compared to length or isEmpty or for other reasons ? I ask because
there are quite a few of those checks in the codebase (below are only some of
them) .
src/java.base/share/classes/java/lang/runtime/ObjectMethods.java:416:
List<String> nameList = "".equals(names) ? List.of() :
List.of(names.split(";"));
src/java.base/share/classes/java/net/NetworkInterface.java:230: return
"".equals(displayName) ? null : displayName;
src/java.base/share/classes/java/net/SocketPermission.java:885: if
(this.wildcard && "".equals(this.cname))
src/java.base/share/classes/java/security/CodeSource.java:466: if
(("".equals(thisHost) || "localhost".equals(thisHost)) &&
src/java.base/share/classes/java/security/CodeSource.java:467:
("".equals(thatHost) || "localhost".equals(thatHost))) {
src/java.base/share/classes/java/text/CompactNumberFormat.java:2546:
!"".equals(compactPatterns[index])) { // ignore empty pattern
src/java.base/share/classes/sun/security/tools/keytool/Main.java:931:
if ("".equals(dest)) {
src/java.base/share/classes/sun/security/tools/keytool/Main.java:939:
if ("".equals(alias)) {
src/java.base/share/classes/sun/security/tools/keytool/Main.java:2510:
if ("".equals(newAlias)) {
src/java.base/share/classes/sun/security/util/SecurityProperties.java:155:
if ("".equals(rawPropVal)) {
src/java.base/share/classes/sun/util/locale/provider/LocaleResources.java:604:
} else if ("".equals(pattern)) {
src/java.desktop/macosx/classes/com/apple/laf/AquaTextFieldSearch.java:246:
if (!text.hasFocus() && "".equals(text.getText())) {
src/java.desktop/macosx/classes/com/apple/laf/AquaTextFieldSearch.java:290:
button.setVisible(!"".equals(text.getText()));
src/java.desktop/share/classes/com/sun/media/sound/JDK13Services.java:175:
if ("".equals(value)) {
src/java.desktop/share/classes/java/awt/FileDialog.java:153:
fileDialog.file = ("".equals(file)) ? null : file;
src/java.desktop/share/classes/java/awt/FileDialog.java:156:
fileDialog.dir = ("".equals(directory)) ? null : directory;
src/java.desktop/share/classes/java/beans/PropertyDescriptor.java:101:
if ("".equals(readMethodName) || "".equals(writeMethodName)) {
src/java.desktop/share/classes/javax/swing/JTable.java:5567: if
("".equals(s)) {
src/java.desktop/share/classes/javax/swing/plaf/basic/BasicComboBoxUI.java:1450:
(!(value instanceof String) || !"".equals(value))) {
src/java.desktop/share/classes/javax/swing/plaf/synth/SynthComboBoxUI.java:551:
if ("".equals(text)) {
src/java.desktop/share/classes/javax/swing/plaf/synth/SynthMenuItemLayoutHelper.java:276:
if (useCheckAndArrow() && (!"".equals(getAccText()))) {
src/java.desktop/share/classes/javax/swing/text/html/CSS.java:1064: if
(borderValue == HTML.NULL_ATTRIBUTE_VALUE || "".equals(borderValue)) {
src/java.desktop/share/classes/javax/swing/undo/AbstractUndoableEdit.java:230:
if (!"".equals(name)) {
src/java.desktop/share/classes/javax/swing/undo/AbstractUndoableEdit.java:257:
if (!"".equals(name)) {
src/java.desktop/share/classes/sun/font/TrueTypeFont.java:696: if
("".equals(encoding)) {
src/java.desktop/share/classes/sun/font/TrueTypeFont.java:1493: while
(!"".equals(key)) {
src/java.desktop/share/classes/sun/java2d/pipe/OutlineTextRenderer.java:76:
if ("".equals(str)) {
src/java.naming/share/classes/com/sun/jndi/url/ldap/ldapURLContext.java:76:
if (!"".equals(dn)) {
src/java.naming/share/classes/com/sun/jndi/url/ldap/ldapURLContextFactory.java:65:
if (!"".equals(dn)) {
src/java.net.http/share/classes/jdk/internal/net/http/HeaderParser.java:232:
if (val != null && "".equals (val)) {
src/java.net.http/share/classes/jdk/internal/net/http/ResponseBodyHandlers.java:215:
if ("".equals(src))
-------------
PR Comment: https://git.openjdk.org/jdk/pull/27523#issuecomment-3359526026
