On Fri, 17 Oct 2025 08:21:07 GMT, Prasanta Sadhukhan <[email protected]> 
wrote:

>> Sergey Nazarkin has updated the pull request incrementally with one 
>> additional commit since the last revision:
>> 
>>   Add EUDC.tte restoration
>
> test/jdk/java/awt/8368882/FallbackFontNPE.sh line 56:
> 
>> 54:    Reg DELETE "${reg_eudc_1252}" /va /f
>> 55: fi
>> 56: Reg import eudc.reg
> 
> Dont think we are allowed to push binary files..Cant we check using 
> `-Duser.language `or 
> `new Locale(ja, JP)`

The test doesn't change locale, and CLI settings doesn't help since native AWT 
library uses system 
[GetSystemDefaultLangID](https://github.com/openjdk/jdk/blob/0a97bef840f8799313a1a55a65d9334e09cc1cf4/src/java.desktop/windows/native/libawt/windows/awt_Win32GraphicsEnv.cpp#L238)
 call.

And unfortunately without this file whole test is useless.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/27551#discussion_r2439061585

Reply via email to