On Thu, 16 Oct 2025 02:02:56 GMT, Prasanta Sadhukhan <[email protected]>
wrote:
>> Test probably was failing due to lack of delay between UI creation and test
>> execution..Delay is added along with rendering frame at screen centre..Also
>> added listener closer to UI creation within EDT
>> CI run for 100 iterations are ok on all platforms..
>
> Prasanta Sadhukhan has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Review comment
LGTM apart from the minor inline suggestion.
test/jdk/javax/swing/JSpinner/8223788/JSpinnerButtonFocusTest.java line 96:
> 94:
> 95: frame.setAlwaysOnTop(true);
> 96: frame.setSize(100, 100);
Minor: I would recommend increasing the width to 300 so that the title of the
frame is visible. (In past there have been cases of stray windows during CI,
having a visible frame title makes it easier to identify problematic tests)
Suggestion:
frame.setSize(300, 100);
-------------
Marked as reviewed by honkar (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/27815#pullrequestreview-3346061853
PR Review Comment: https://git.openjdk.org/jdk/pull/27815#discussion_r2436814853
