On Fri, 26 Sep 2025 20:46:37 GMT, Phil Race <[email protected]> wrote:
>> Ravi-Patel8 has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - Updated Comments >> >> Signed-off-by: Ravi.Patel8 <[email protected]> >> - Add catch block to log exception details for troubleshooting printer >> command >> >> Signed-off-by: Ravi.Patel8 <[email protected]> > > src/java.desktop/unix/classes/sun/print/PrintServiceLookupProvider.java line > 879: > >> 877: bufferedReader = new BufferedReader(reader); >> 878: String line; >> 879: results = new ArrayList<>(); > > I'm surprised there's no NPE propagated. > > It looks like this line was in the middle of a huge re-indented block so it > wasn't easy to spot it was removed, which can only have been an editing > accident. > > Looks OK to me but @honkar-jdk please take a look too.. Looks like I missed looking at this PR earlier. I'll look into it today. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/27482#discussion_r2402778720
