On Tue, 7 Oct 2025 10:53:13 GMT, Prasanta Sadhukhan <[email protected]>
wrote:
>> Test fails to pick red color from JLabel in ubuntu24.04 even though it
>> passes is ubuntu 22.04.
>> Seems like the red pixel from the font is not being picked up despite the
>> fact that label foreground color actually is rendered in red.
>>
>> It is seen in ubuntu 22.04 the font used for JLabel is "family=DejaVu
>> Sans,name=DejaVu Sans,style=plain,size=12"
>> while in ubuntu 24.04 the font used for JLabel is "family=Noto
>> Sans,name=Noto Sans,style=plain,size=12"
>>
>> I have made it consistent across version using same font and made it larger
>> and bold and using such text for easier pickup of redpixel.
>> It passes in all platforms including ubuntu24.04
>
> Prasanta Sadhukhan has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Use full block red char
Marked as reviewed by aivanov (Reviewer).
test/jdk/javax/swing/plaf/basic/BasicHTML/bug4248210.java line 74:
> 72: }
> 73:
> 74: JLabel label = new JLabel("<html><body>\u2588 \u2588 \u2588
> \u2588</body></html>");
Suggestion:
JLabel label = new
JLabel("<html><body>\u2588\u2588\u2588\u2588</body></html>");
No one sees the text, spaces aren't necessary.
A comment will clarify what the Unicode character is used and why. Otherwise,
it looks good to me.
-------------
PR Review: https://git.openjdk.org/jdk/pull/27635#pullrequestreview-3311132957
PR Review Comment: https://git.openjdk.org/jdk/pull/27635#discussion_r2411354488
