On Thu, 30 Oct 2025 21:54:17 GMT, Alexander Zuev <[email protected]> wrote:

>> The JBS issue has a long discussion and explanation but here's a short 
>> version.
>> Instead of having baked in names of distros in the code that figures out 
>> names for font configuration files for Linux
>> use the standard ID and VERSION_ID fields in /etc/os-release which is now 
>> standard.
>> even systemd doesn't work if it does not exist 
>> https://0pointer.de/blog/projects/os-release
>> And if it doesn't we just use "Linux" as the name.
>
> Changes looks reasonable and i checked that there is no usage of osVersion 
> not guarded by the null check because right now of the /etc/os-release is not 
> readable the value i think will be left as null? But anyways the code that 
> uses it assumes that it can be null so all is well in this department. At the 
> time i wrote this comment the CSR issue is still being filled in - i will 
> take another look tomorrow.

@azuev-java please review the CSR too.
@prsadhuk please review

-------------

PR Comment: https://git.openjdk.org/jdk/pull/28073#issuecomment-3478132216

Reply via email to