On Tue, 4 Nov 2025 13:24:01 GMT, Alexey Ivanov <[email protected]> wrote:

>> It fails because the code I proposed is plainly wrong.
>> 
>> 
>>     public static Component findSubComponent(Component parent, String 
>> className) {
>>         return findComponentImpl((Container) parent,
>>                                  c -> 
>> c.getClass().getName().contains(className));
>>     }
>
> I would even format it like this, wrapping all the chained calls:
> 
> 
>     public static Component findSubComponent(Component parent, String 
> className) {
>         return findComponentImpl((Container) parent,
>                                  c -> c.getClass()
>                                        .getName()
>                                        .contains(className));
>     }

I also suggest calling `findComponent` instead of `findComponentImpl` — then 
you can remove the line *“Always run this method on the EDT thread”* from the 
javadoc comment.

Also, change “a sub component” to “a subcomponent”.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/27944#discussion_r2490583144

Reply via email to