On Thu, 6 Nov 2025 17:51:44 GMT, Alexey Ivanov <[email protected]> wrote:

>> Prasanta Sadhukhan has updated the pull request incrementally with one 
>> additional commit since the last revision:
>> 
>>   Review fix
>
> test/jdk/javax/swing/text/GlyphView/TestGlyphBGHeight.java line 70:
> 
>> 68: 
>> 69:         final BufferedImage img = createImage();
>> 70:         SwingUtilities.invokeAndWait(() -> {
> 
> You can create the text component directly on the main thread. The component 
> will never be accessed from EDT if you perform all the operations on the main 
> thread.

It depends, the code may post some events on EDT which will cause the component 
be accessed on different threads, for example via [JComponent.revalidate 
](https://github.com/openjdk/jdk/blob/066810c877b206a66cc87537487b17f0481646c3/src/java.desktop/share/classes/javax/swing/JComponent.java#L4943)

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/28173#discussion_r2505762629

Reply via email to