On Sat, 8 Nov 2025 23:26:19 GMT, Alexander Zuev <[email protected]> wrote:
>> The problem is that we do not correct the icon and text re-alignment that >> happens when we call SwingUtilities.layoutCompoundLabel >> >> Here's the comparison of the alignment before and after the fix >> Before: >> <img width="708" height="788" alt="before_fix" >> src="https://github.com/user-attachments/assets/9bcd3fb1-5186-45ea-98d9-d2bc534ca51e"; >> /> >> After: >> <img width="708" height="788" alt="after_fix" >> src="https://github.com/user-attachments/assets/ec6dfdf5-a515-4ef6-b70d-cc4019e00826"; >> /> > > Alexander Zuev has updated the pull request incrementally with one additional > commit since the last revision: > > Use correct bug id in the test. src/java.desktop/macosx/classes/com/apple/laf/AquaMenuPainter.java line 538: > 536: checkIconR.x = w - (checkIconR.x + checkIconR.width); > 537: if (menuItem.getHorizontalTextPosition() != > SwingConstants.CENTER) { > 538: int d = textR.x - iconR.x; `d` refers to difference ? Could be `diff` for readability ? ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/28210#discussion_r2516754264
