On Wed, 12 Nov 2025 12:29:26 GMT, Prasanta Sadhukhan <[email protected]>
wrote:
>> If we pass null as highlight and shadow color to
>> `BorderFactory.createBevelBorder` and `createSoftBevelBorder`
>> it throws NPE which is not mentioned in the spec as the expected outcome.
>> Fixed the NPE and the spec
>
> Prasanta Sadhukhan has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Review comment
Changes requested by aivanov (Reviewer).
> I guess spec clarification isn't strictly necessary for this PR..\
> …Any objections?
I've been wondering why I can't see any javadoc changes.
Sounds reasonable to me.
test/jdk/javax/swing/border/TestBevelBorderParam.java line 59:
> 57: str.append("BevelBorder constructor throws NPE for null
> highlight and shadow");
> 58: }
> 59: if (str.length() != 0) {
Suggestion:
}
if (str.length() != 0) {
The `if` statement also starts a new logical block.
-------------
PR Review: https://git.openjdk.org/jdk/pull/27949#pullrequestreview-3453635218
PR Comment: https://git.openjdk.org/jdk/pull/27949#issuecomment-3522134135
PR Review Comment: https://git.openjdk.org/jdk/pull/27949#discussion_r2518450267
