On Thu, 13 Nov 2025 23:20:18 GMT, Harshitha Onkar <[email protected]> wrote:
> This test started to fail on macOS26 due to color inconsistency at certain > points. > Color tolerance has been added as a fix. > > The color tolerance for the dominant component (eg Color.RED - dominant > component is red) is set less (delta /PRIMARY_TOLERANCE = 2) and for > non-dominant (For Color.RED - Green and Blue are non-dominant) is set more > (delta / TOLERANCE=30). This ensures we are checking for shades > (brighter/lighter) of the expected color. > > Since the issue is only seen on macOS, I have set both PRIMARY_TOLERANCE & > TOLERANCE to 2 on other platforms to keep the test almost close to the > original one. > > Tested locally on macOS 26.0.1 and 26.1 and fix works as expected. > > CI testing on other platforms looks good and no regressions are observed > (Link added to JBS). Looks good. ------------- Marked as reviewed by kizune (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/28312#pullrequestreview-3462251667
