> The only significant change here is to ensure that all SampleModel types
> throw a specified exception if a client
> calls any of the following methods with a negative width or height.
> getPixels(..)
> setPixels(..)
> getSamples(..)
> setSamples(..)
>
> The rest is fixing the javadoc to properly describe what happens and some
> minor cleanup.
> I use {@inheritDoc} to avoid repeating the super-class doc. And no one now
> has to tediously compare them.
> I could just delete the javadoc but that would cause no javadoc to be
> generated for an overridden method.
> There were a couple of surprises with {@inheritDoc} and the one I had to deal
> with is that declared RuntimeExceptions
> are not inherited. You need to explicitly re-add them. This because if it
> isn't an exception in the method signature (as in foo() throws
> BarException), and instead you only have "@throws BarException" it will not
> be inherited.
>
> I added a test which verifies the behaviour for illegal arguments.
>
> CSR is here https://bugs.openjdk.org/browse/JDK-8369623
Phil Race has updated the pull request incrementally with one additional commit
since the last revision:
6185110
-------------
Changes:
- all: https://git.openjdk.org/jdk/pull/27754/files
- new: https://git.openjdk.org/jdk/pull/27754/files/3d7f9272..99d5d146
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk&pr=27754&range=01
- incr: https://webrevs.openjdk.org/?repo=jdk&pr=27754&range=00-01
Stats: 12 lines in 5 files changed: 12 ins; 0 del; 0 mod
Patch: https://git.openjdk.org/jdk/pull/27754.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/27754/head:pull/27754
PR: https://git.openjdk.org/jdk/pull/27754
