On Tue, 18 Nov 2025 15:01:14 GMT, Christian Heilmann <[email protected]> wrote:
>> This PR fixes a bug that caused no or the wrong set of pages to be printed >> when using page ranges on macOS. >> >> The main fix is to change the 'location' value of the returned NSRange from >> the knowsPageRange method to 1 in the native class PrinterView.m. > > Christian Heilmann has updated the pull request incrementally with three > additional commits since the last revision: > > - Update PrinterView.m > - Update PrinterView.h > - Update CPrinterJob.m While this PR was on review, the`test/jdk/java/awt/print/PrinterJob/PageRanges.java` test was updated to the `PassFailJFrame` framework. The test can now be run with jtreg and, therefore, it can be used verify the fix. Thus, *add 8297191 to the `@bug` tag in `PrinterJob/PageRanges.java`*. [I had already asked for it](https://github.com/openjdk/jdk/pull/11266#pullrequestreview-3152815416). ------------- Changes requested by aivanov (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/11266#pullrequestreview-3506975619
