On Mon, 1 Dec 2025 20:38:13 GMT, Phil Race <[email protected]> wrote:

>> Prasanta Sadhukhan has updated the pull request incrementally with one 
>> additional commit since the last revision:
>> 
>>   javadoc clarify
>
> src/java.desktop/share/classes/javax/swing/JList.java line 2510:
> 
>> 2508:      * @param direction less or equal to zero to scroll up/back,
>> 2509:      *                  greater than zero for down/forward
>> 2510:      * @return the "unit" increment for scrolling in the specified 
>> direction;
> 
> I don't think all of this should be in the @return statement.
> I think it should just say
> @return the non-negative "unit" increment for scrolling in the specified 
> direction.
> 
> And the explanatory text should be in the body of the doc and be (something 
> like) this, after the very first sentence of the existing doc.
> "The scrolling distance returned will be positive, unless scrolling for the 
> specified parameters is already at its furthest extent, in which case it will 
> return zero".

OK updated both PR and CSR

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/26500#discussion_r2579410773

Reply via email to