On Tue, 25 Nov 2025 09:26:21 GMT, Alexey Ivanov <[email protected]> wrote:
>> Sergey Bylokhov has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains two additional
>> commits since the last revision:
>>
>> - Merge branch 'openjdk:master' into JDK-8371501
>> - 8371501: Change IAE to NPE in java.awt.image.Kernel when data is null
>
> test/jdk/java/awt/image/ConvolveOp/KernelInitialisationTest.java line 49:
>
>> 47: System.err.println("Expected: " + expected);
>> 48: System.err.println("Actual: " + actual);
>> 49: throw new RuntimeException("Test failed");
>
> Does it make sense to include the class names in the error message too? It
> helps analysing the failure, you know the reason without opening the log file.
I agree it might be useful, but it’s not that critical. I’ll follow that
pattern in the next tests.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/28249#discussion_r2582756816
