On Wed, 26 Nov 2025 16:25:04 GMT, Christian Heilmann <[email protected]> wrote:
>> This PR fixes a bug that caused no or the wrong set of pages to be printed >> when using page ranges on macOS. >> >> The main fix is to change the 'location' value of the returned NSRange from >> the knowsPageRange method to 1 in the native class PrinterView.m. > > Christian Heilmann has updated the pull request incrementally with two > additional commits since the last revision: > > - Merge branch 'pr/8297191' of https://github.com/christianheilmann/jdk into > pr/11266 > - added 8297191 to @bug I run on macOS Tahoe 26.1 on an MacBook Air M3 all tests containing PageRanges: make test TEST="jtreg:test/jdk/java/awt/print/Dialog/DestinationTest.java jtreg:test/jdk/java/awt/print/PrinterJob/DlgAttrsBug.java jtreg:test/jdk/java/awt/print/PrinterJob/PageRanges.java jtreg:test/jdk/java/awt/print/PrinterJob/PageRangesDlgTest.java jtreg:test/jdk/javax/print/attribute/PageRangesException.java jtreg:test/jdk/java/awt/print/PrinterJob/PrintAttributeUpdateTest.java jtreg:test/jdk/java/awt/print/PrinterJob/PrintDlgPageable.java jtreg:test/jdk/java/awt/PrintJob/SaveDialogTitleTest.java jtreg:test/jdk/javax/print/attribute/ServiceDlgPageRangeTest.java jtreg:test/jdk/javax/print/attribute/SidesPageRangesTest.java" JTREG="MANUAL=true" ============================== Test summary ============================== TEST TOTAL PASS FAIL ERROR SKIP jtreg:test/jdk/java/awt/print/Dialog/DestinationTest.java 1 1 0 0 0 jtreg:test/jdk/java/awt/print/PrinterJob/DlgAttrsBug.java 1 1 0 0 0 jtreg:test/jdk/java/awt/print/PrinterJob/PageRanges.java 1 1 0 0 0 jtreg:test/jdk/java/awt/print/PrinterJob/PageRangesDlgTest.java 1 1 0 0 0 jtreg:test/jdk/java/awt/print/PrinterJob/PrintAttributeUpdateTest.java 1 1 0 0 0 jtreg:test/jdk/java/awt/print/PrinterJob/PrintDlgPageable.java 1 1 0 0 0 jtreg:test/jdk/java/awt/PrintJob/SaveDialogTitleTest.java >> 1 0 0 1 >> 0 << jtreg:test/jdk/javax/print/attribute/ServiceDlgPageRangeTest.java 1 1 0 0 0 ============================== TEST FAILURE make test TEST="jtreg:test/jdk/java/awt/print/PrinterJob/PageRanges.java jtreg:test/jdk/javax/print/attribute/SidesPageRangesTest.java" ============================== TEST FAILURE ============================== Test summary ============================== TEST TOTAL PASS FAIL ERROR SKIP jtreg:test/jdk/javax/print/attribute/PageRangesException.java 1 1 0 0 0 jtreg:test/jdk/javax/print/attribute/SidesPageRangesTest.java 1 1 0 0 0 ============================== TEST SUCCESS I don't know the command on how to run the SaveDialogTitleTest successfully. All other tests containing PageRanges were run successfully. ------------- PR Comment: https://git.openjdk.org/jdk/pull/11266#issuecomment-3607291463
