On Wed, 3 Dec 2025 04:39:02 GMT, Sergey Bylokhov <[email protected]> wrote:
> This patch adds missing `@Override` annotations to methods in the > `com.sun.java.swing.plaf.gtk` package that override methods from a superclass > or interface. > Only source annotations are added; there are no behavioral changes. > > The previous patch for `com.sun.beans` can be found here: > https://github.com/openjdk/jdk/pull/27887. > > BTW, does anybody know why the gtk l&f is located in the shared code? > Possibly we could move it to the unix folder, similar to how the windows l&f > was moved to the windows folder in > https://bugs.openjdk.org/browse/JDK-8189656 ? Marked as reviewed by prr (Reviewer). > BTW, does anybody know why the gtk l&f is located in the shared code? My guess is that it is because motif is also located in shared, and it was the 'successor' to motif which was considered a multi-platform L&F because CDE/Motif was for multiple OSes. I don't know if GTK L&F can be created/used/run except where the theming engine is available. Possibly in the very beginning it could have been. ------------- PR Review: https://git.openjdk.org/jdk/pull/28624#pullrequestreview-3564376573 PR Comment: https://git.openjdk.org/jdk/pull/28624#issuecomment-3638868096
