On Sat, 13 Dec 2025 00:33:30 GMT, Daniel Gredler <[email protected]> wrote:
> One of the possible code paths for `TextLayout.getPixelBounds(...)` actually > draws the text on a `Graphics2D` and checks the image pixels afterwards. The > text is drawn over a white background, so if the user sets the font's > foreground color to white then the text pixels cannot be detected (white on > white). > > This PR fixes the issue by removing the code that sets the background to > white, leaving the background as the default ARGB color (0 = transparent > black). This does not cause a new problem for users who might set their font > foreground color to transparent black, because transparent font foreground > colors always return an empty bounds anyway (by virtue of being transparent). > > The updated code should also be slightly faster since it's doing less work, > though I haven't run any performance tests. all our existing normal tests passed, as well as the new one. ------------- Marked as reviewed by prr (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/28809#pullrequestreview-3600283604
