Understood -- thanks! Daniel
On Tue, Dec 23, 2025 at 12:22 AM Philip Race <[email protected]> wrote: > Anyone doing that would be on their own. So also if it causes any tests > to fail I'd be surprised. > I wasn't sure how much constructor code reorganisation would be needed > but it doesn't look too bad. > > -phil. > > On 12/22/25 7:37 AM, Daniel Gredler wrote: > > Hi guys, > > > > The `FontRenderContext` class does not have any setters for the data > > which it carries, so from a public API perspective it is immutable. > > However, the private instance variables are not declared final. I was > > thinking about raising a small PR to make the instance variables > > final, to more clearly indicate the immutability of the class. Is this > > considered a backwards-compatible change? Or is it considered > > non-backwards-compatible, since users can technically use reflection > > to fiddle with the class internals (and since final will soon more > > definitely mean final)? > > > > Take care, > > > > Daniel > > > > > >
