On Tue, 23 Dec 2025 20:55:39 GMT, Alexey Ivanov <[email protected]> wrote:
>> Khalid Boulanouare has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fixes minor conflict origin compilation issue
>
> test/jdk/java/awt/Mixing/AWT_Mixing/SimpleOverlappingTestBase.java line 177:
>
>> 175: "focus");
>> 176: }
>> 177: clickAndBlink(robot, lLoc);
>
> Is `clickAndBlink` supposed to fix the focus issue?
>
> Is it still required if the ancestor received the focus? (If it didn't, you
> throw an exception.)
I had duplicated code during merge, by mistake. This is fixed now and
clickAndBlink happens only when we get focus.
> test/jdk/java/awt/Mixing/AWT_Mixing/SimpleOverlappingTestBase.java line 189:
>
>> 187: } catch (InterruptedException e) {
>> 188: throw new RuntimeException(e);
>> 189: }
>
> This indented block is exact duplicate of the block above.
Remved duplicate code.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/26625#discussion_r2650824338
PR Review Comment: https://git.openjdk.org/jdk/pull/26625#discussion_r2650819338
