On Fri, 2 Jan 2026 08:13:40 GMT, Jayathirth D V <[email protected]> wrote:

>> Jeremy Wood has updated the pull request incrementally with one additional 
>> commit since the last revision:
>> 
>>   8374377: test correctness of non-interlaced PNGs too
>>   
>>   Also this removes the performance comparison. (As of this writing there's 
>> a separate 
>> `test/micro/org/openjdk/bench/sun/awt/image/PNGImageDecoder_8bit_uninterlaced.java`
>>  file used to demonstrate that this change is more performant.)
>
> test/micro/org/openjdk/bench/sun/awt/image/PNGImageDecoder_8bit_uninterlaced.java
>  line 23:
> 
>> 21:  * questions.
>> 22:  */
>> 23: package org.openjdk.bench.sun.misc;
> 
> package should be `org.openjdk.bench.sun.awt.image`

This is updated

> test/micro/org/openjdk/bench/sun/awt/image/PNGImageDecoder_8bit_uninterlaced.java
>  line 33:
> 
>> 31: import org.openjdk.jmh.annotations.State;
>> 32: import org.openjdk.jmh.annotations.Warmup;
>> 33: import org.openjdk.jmh.infra.Blackhole;
> 
> We need to import `import org.openjdk.jmh.annotations.Benchmark;` and `import 
> org.openjdk.jmh.annotations.Setup;` also. Otherwise i am seeing compilation 
> errors.

This is updated

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/29004#discussion_r2658709686
PR Review Comment: https://git.openjdk.org/jdk/pull/29004#discussion_r2658709693

Reply via email to