On Wed, 21 Jan 2026 18:48:58 GMT, Phil Race <[email protected]> wrote:
>> Some of the medialib native functions implementing Convolve read data from >> arrays when it is not needed or used instead of reading just what is needed >> and used. >> This is detected as a read out of bounds. It is limited and hasn't been seen >> to result in any crashes without ASAN, and the OOB values that are read are >> never used so there's a very limited problem. >> The changes here make the mlib_ImageConv_*nw.c files match what happens in >> the mlib_ImageConv_*ext.c files which read just the data they need. >> The changes are fairly mechanical but there could be copy/paste errors for a >> reviewer to find. >> >> Not easy to provide a test case, building with --enable-asan is needed and >> for me it works only on macOS. >> I did that and ran all our existing automated tests on our CI systems. > > Phil Race has updated the pull request with a new target base due to a merge > or a rebase. The pull request now contains two commits: > > - Merge > - 8373626 src/java.desktop/share/native/libmlib_image/mlib_ImageConv_D64nw.c line 223: > 221: p2 = sp[0]; > 222: > 223: sp += 2*sll; Is this a copypaste error? The sp is incremented twice in a row? ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/29257#discussion_r2714908645
