On Fri, 30 Jan 2026 13:00:34 GMT, Alexey Ivanov <[email protected]> wrote:
>> Phil Race has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 8376297
>
> test/jdk/java/awt/image/GetSampleSizeTest.java line 47:
>
>> 45: ComponentSampleModel csm =
>> 46: new ComponentSampleModel(DataBuffer.TYPE_BYTE,
>> 47: width, height, 1, width, bandOffsets);
>
> I still think the lines 46–47 should be indented by 4 more spaces: either is
> a continuation line of the line above.
>
>
> Suggestion:
>
> ComponentSampleModel csm =
> new ComponentSampleModel(DataBuffer.TYPE_BYTE,
> width, height, 1, width, bandOffsets);
>
>
> However, the indentation is somewhat consistent now: lines 58 and 69 are also
> indented by 4 spaces only. Yet they should be indented by 8 spaces.
I don't know where this 8 spaces rule came from and I thought you meant it for
the 2nd or later continuation line, not for the first.
My preferred style is to always indent 4 more except I like to line up the arg
lists vertically.
> test/jdk/java/awt/image/GetSampleSizeTest.java line 75:
>
>> 73: throw new RuntimeException("Unexpected numBands");
>> 74: }
>> 75: try {
>
> Suggestion:
>
> if (numBands != 4) {
> throw new RuntimeException("Unexpected numBands");
> }
> try {
>
> The brace that closes the `if` block is still indented incorrectly, it should
> be in the same column as `i` and `t` of `if` above and `try` below.
ok
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/29457#discussion_r2755945238
PR Review Comment: https://git.openjdk.org/jdk/pull/29457#discussion_r2755944985
