On Fri, 6 Feb 2026 14:47:44 GMT, Khalid Boulanouare <[email protected]> wrote:
>> This PR will consolidate fixes of the following bugs: >> >> https://bugs.openjdk.org/browse/JDK-8361188 >> https://bugs.openjdk.org/browse/JDK-8361189 >> https://bugs.openjdk.org/browse/JDK-8361190 >> https://bugs.openjdk.org/browse/JDK-8361191 >> https://bugs.openjdk.org/browse/JDK-8361192 >> https://bugs.openjdk.org/browse/JDK-8361193 >> https://bugs.openjdk.org/browse/JDK-8361195 >> >> This PR depends on https://github.com/openjdk/jdk/pull/25971 >> >> For test : java/awt/Mixing/AWT_Mixing/JComboBoxOverlapping.java, the fix >> suggested is to return false in method isValidForPixelCheck for embedded >> frame, in which case the component is set to null. For more details see bug: >> [JDK-8361188](https://bugs.openjdk.org/browse/JDK-8361188) >> >> For test : test/jdk/java/awt/Mixing/AWT_Mixing/MixingPanelsResizing.java, I >> had to create a a tolerance color matching method for mac for the tests to >> pass. Also, the jbuttons needed to have different color than the color of >> the background frame, in order for test to pass. For more detail see bug: >> https://bugs.openjdk.org/browse/JDK-8361193 >> >> For test : test/jdk/java/awt/Mixing/AWT_Mixing/JSplitPaneOverlapping.java, >> it seems that color selected for lightweight component matches the >> background color of the frame. And this will cause the test to fail when >> matching colors. Choosing any color different than the background color will >> get the test to pass. For more details, see bug: >> https://bugs.openjdk.org/browse/JDK-8361192 >> >> For test test/jdk/java/awt/Mixing/AWT_Mixing/JPopupMenuOverlapping.java, it >> looks like the frame when visible, the popup test does not work properly. >> The frame needs to be hidden for the test to click on popup. For more >> details see bug: https://bugs.openjdk.org/browse/JDK-8361191 >> >> For test test/jdk/java/awt/Mixing/AWT_Mixing/JMenuBarOverlapping.java, the >> test runs successfully but it times out after the default 2 minutes of >> jtreg. increasing the timeout to 3 minutes get the test to pass. For more >> details please refer to bug: https://bugs.openjdk.org/browse/JDK-8361190 > > Khalid Boulanouare has updated the pull request with a new target base due to > a merge or a rebase. The pull request now contains 124 commits: > > - Merge branch 'openjdk:master' into jdk-8360498 > - Changes point location to prevent pixelpick error in some macosx-aarch64 > machines > - Merge branch 'openjdk:master' into jdk-8360498 > - Removes some mixing tests from problem list > - Fixes few issues when sorting formatting ... > - Updates formatting and removes extra blank line > - Removes blank lines > - Removes blank lines > - Applies suggested change > - Simplifies return expression > - ... and 114 more: https://git.openjdk.org/jdk/compare/9f13ec1c...c21fc2a1 test/jdk/java/awt/Mixing/AWT_Mixing/JComboBoxOverlapping.java line 83: > 81: frame.add(cb); > 82: propagateAWTControls(frame); > 83: frame.setLocationRelativeTo(null); Did you forget to remove from here? test/jdk/java/awt/Mixing/AWT_Mixing/MixingPanelsResizing.java line 253: > 251: // it for now. > 252: public static void main(String args[]) throws Exception { > 253: try { I don't think try-catch is required here. test/jdk/java/awt/Mixing/AWT_Mixing/OverlappingTestBase.java line 385: > 383: private static boolean isValidForPixelCheck(Component component) { > 384: return !(component == null || > 385: (component instanceof java.awt.Scrollbar) || Suggestion: (component instanceof Scrollbar) || Same can be done to Button too by adding import. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/26625#discussion_r2785873831 PR Review Comment: https://git.openjdk.org/jdk/pull/26625#discussion_r2785890828 PR Review Comment: https://git.openjdk.org/jdk/pull/26625#discussion_r2785894508
