> If we use `new AccessibleRole("AXLink") {}`, then VoiceOver reads this more 
> like other native apps.
> 
> There isn't a similar precedent in CAccessibility for creating custom 
> AccessibleRoles, so I won't mind if this PR is declined. (But I don't know 
> off the top of my head where else to inject code to get the desired result...)

Jeremy Wood has updated the pull request incrementally with two additional 
commits since the last revision:

 - 8377745: creating new LinkAccessibility
   
   This helps convert from AccessibleRole.HYPERLINK to the new 
LinkAccessibility.
   
   The new LinkAccessible still references 
`CommonTextAccessibility<NSAccessibilityStaticText>`.
   
   This (both the subject matter and the programming language) is outside of my 
area of expertise, but the unit test passes.
   
   This is based on this feedback:
   https://github.com/openjdk/jdk/pull/29686#issuecomment-3899448303
 - Revert "8377745: use custom "AXLink" AccessibleRole"
   
   This reverts commit d66355973918458352d15174a2cf21a177763c23.

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/29686/files
  - new: https://git.openjdk.org/jdk/pull/29686/files/49c63a19..96159c51

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=29686&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=29686&range=00-01

  Stats: 63 lines in 4 files changed: 42 ins; 10 del; 11 mod
  Patch: https://git.openjdk.org/jdk/pull/29686.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/29686/head:pull/29686

PR: https://git.openjdk.org/jdk/pull/29686

Reply via email to