On Tue, 17 Feb 2026 19:42:41 GMT, Alexey Ivanov <[email protected]> wrote:
>> Sergey Bylokhov has updated the pull request incrementally with one >> additional commit since the last revision: >> >> review feedback > > test/jdk/java/awt/ColorClass/ColorARGBConstructorTest.java line 49: > >> 47: int expA = hasAlpha ? (argb >>> 24) : 0xFF; >> 48: int expR = (argb >> 16) & 0xFF; >> 49: int expG = (argb >> 8) & 0xFF; > > This was not what I meant: > > Suggestion: > > int expA = hasAlpha ? (argb >>> 24) : 0xFF; > int expR = (argb >>> 16); > int expG = (argb >>> 8); > > > or > > > Suggestion: > > int expA = hasAlpha ? ((argb >> 24) & 0xFF) : 0xFF; > int expR = (argb >> 16) & 0xFF; > int expG = (argb >> 8) & 0xFF; I understand that, but prefer >>> for alpha only. "()" is added to make operation order clear. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/29734#discussion_r2818782217
