On Tue, 17 Feb 2026 22:10:00 GMT, Alexey Ivanov <[email protected]> wrote:
>> Phil Race has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 8377568
>
> src/java.desktop/share/classes/java/awt/image/DataBuffer.java line 555:
>
>> 553: throw new ArrayIndexOutOfBoundsException("Invalid index
>> (bankOffset+i) is " +
>> 554: "(" + offsets[bank] + " + " + i + ") which is too large
>> for size : " + size);
>> 555: }
>
> No, it wasn't what I meant. The `throw` statement should be indented by 4
> spaces—now there are 6 spaces. The continuation lines should be indented by 8
> spaces, but there were 7. This is the recommendation from the [Java Style
> Guide for
> Indentation](https://www.oracle.com/java/technologies/javase/codeconventions-indentation.html).
They are (now) consistently 4. I don't think I've ever used 8 for continuation.
I use 4 (more) unless there's a natural alignment that seems attractive.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/29766#discussion_r2819390886
