On Thu, 19 Feb 2026 18:22:24 GMT, Phil Race <[email protected]> wrote:
>> Prasanta Sadhukhan has updated the pull request incrementally with two >> additional commits since the last revision: >> >> - Remove unused imports >> - Remove unused imports > > src/java.desktop/share/classes/javax/swing/plaf/basic/BasicProgressBarUI.java > line 731: > >> 729: int amountFull = getAmountFull(b, barRectWidth, barRectHeight); >> 730: >> 731: Graphics g2 = null; > > Naming it g2 implies it is a Graphics2D .. I guess you were trying to > minimize lines that need to change but it is better to name the Graphics just > 'g'. and may be use g2d for the Graphics2D ? > So we'll see every line that needs to change. > > Also if I'm reading this right you just draw a 1 user space pixel line if its > not a G2D ? > The use of barRectHeight for the stroke width tells me that you need > something more like fillRect as an alternative don't you ? > > Also the cellspacing case (lines 749-751) looks like it needs individual > fillRect calls. Variables renamed..and fillRect used instead of drawLine...also, individual fillRect calls used for cellSpacing case.. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/29752#discussion_r2832117051
