On Mon, 23 Feb 2026 04:56:55 GMT, Renjith Kannath Pariyangad 
<[email protected]> wrote:

>> Hi Reviewers,
>> 
>> Add a parser to convert other exception to "PrinterException" for resolving 
>> this issue. Updated existing test for covering 'Windows' and 'Linux' 
>> platform.
>> 
>> Please review and let me know your suggestions.
>
> Renjith Kannath Pariyangad has updated the pull request incrementally with 
> one additional commit since the last revision:
> 
>   Updated based on suggesion

test/jdk/java/awt/print/PrinterJob/ExceptionFromPrintableIsIgnoredTest.java 
line 66:

> 64:                 "Test started. threadType='%s', exceptionType='%s'",
> 65:                 threadType, exceptionType));
> 66: 

I believe this test is passing without the fix...It would be better to have a 
test where you can throw a RTE forcefully and which would fail if it gets an 
exception other than PrinterException

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/29733#discussion_r2844722689

Reply via email to