On Thu, 19 Feb 2026 20:04:13 GMT, Alexey Ivanov <[email protected]> wrote:

>> As I 
>> [mentioned](https://github.com/openjdk/jdk/pull/11266#issuecomment-3577688690)
>>  in #11266, I wrote an automatic test `PageRangesAuto.java` that verifies if 
>> page range is printed correctly. I used this test to validate the fix for 
>> [JDK-8297191](https://bugs.openjdk.org/browse/JDK-8297191) in addition to 
>> the existing one, `java/awt/print/PrinterJob/PageRanges.java`.
>> 
>> With this PR, I'm contributing the test to OpenJDK.
>> 
>> Without the fix for JDK-8297191, the test fails with the following error 
>> messages:
>> 
>> <details>
>> <summary>test log</summary>
>> 
>> 
>> java.lang.Error: Not all pages printed in PRINTABLE within the range [2, 3]: 
>> {2}
>> java.lang.Error: Not all pages printed in PRINTABLE within the range [3, 6]: 
>> {4, 5}
>> java.lang.Error: Not all pages printed in PRINTABLE within the range [4, 7]: 
>> {6}
>> java.lang.Error: Not all pages printed in PRINTABLE within the range [7, 7]: 
>> {}
>> java.lang.Error: Not all pages printed in PRINTABLE within the range [9, 
>> 10]: {}
>> java.lang.Error: Not all pages printed in PRINTABLE within the range [10, 
>> 10]: {}
>> java.lang.Error: Not all pages printed in PAGEABLE within the range [2, 3]: 
>> {2}
>> java.lang.Error: Not all pages printed in PAGEABLE within the range [3, 6]: 
>> {4, 5}
>> java.lang.Error: Not all pages printed in PAGEABLE within the range [4, 7]: 
>> {6}
>> java.lang.Error: Not all pages printed in PAGEABLE within the range [7, 7]: 
>> {}
>> java.lang.Error: Not all pages printed in PAGEABLE within the range [9, 10]: 
>> {}
>> java.lang.Error: Not all pages printed in PAGEABLE within the range [10, 
>> 10]: {}
>> Exception in thread "main" java.lang.RuntimeException: Errors detected: 12. -
>> java.lang.Error: Not all pages printed in PRINTABLE within the range [2, 3]: 
>> {2}
>>      at PageRangesAuto.main(PageRangesAuto.java:146)
>> 
>> </details>
>
> Alexey Ivanov has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   Use the first page of the rage in the filename

test/jdk/java/awt/print/PrinterJob/PageRangesAuto.java line 97:

> 95:         String fileName = pageRange == null
> 96:                           ? baseName + "-all.pdf"
> 97:                           : String.format("%s-%d-%d.pdf",

I believe `Destination` creates file in .prn or .ps format and not .pdf..
https://docs.oracle.com/en/java/javase/24/docs/api/java.desktop/javax/print/attribute/standard/Destination.html

> A common use for this attribute will be applications which want to redirect 
> output to a local disk file : eg."file:out.prn"

I am not able to open this file atleast in Windows as Acrobat fails to 
recognize the file type even though its pdf

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/29660#discussion_r2850827650

Reply via email to