On Wed, 25 Feb 2026 12:04:38 GMT, Daniel Gredler <[email protected]> wrote:
>> On macOS, `GlyphMetrics` advance provides only the x-component of the >> advance, not the y-component. This is usually not an issue, since most text >> does not have any y-component advance. However, if the font is rotated, this >> does cause problems. >> >> This bug was discovered during fixing of the manual test >> `java/awt/print/PrinterJob/PrintTextTest.java` (this test is intended to >> test printing, but this bug was actually causing the `GlyphVector`s on page >> 8 to be drawn incorrectly on screen, not just on paper). >> >> `FileFontStrike.getGlyphMetrics( )` was helpful as a guide regarding the >> expected behavior of `CStrike.getGlyphMetrics( )`. >> >> Tested on mac, Linux and Windows: >> - make test TEST="jtreg:test/jdk/java/awt/font" >> - make test TEST="jtreg:test/jdk/java/awt/Graphics2D/DrawString" > > Daniel Gredler has updated the pull request incrementally with one additional > commit since the last revision: > > Add defensive check for null ptr Marked as reviewed by psadhukhan (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk/pull/29726#pullrequestreview-3865436939
