On Thu, 5 Mar 2026 17:33:04 GMT, Alexey Ivanov <[email protected]> wrote:
>> Prasanta Sadhukhan has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> AUtomate test
>
> test/jdk/java/awt/PrintJob/TestPrintNoException.java line 50:
>
>> 48: });
>> 49: Toolkit tk = Toolkit.getDefaultToolkit();
>> 50: PrintJob pj = null;
>
> `pj` can be declared where it's used. You may still call `pj.end()` to
> indicate the test doesn't print anything.
ok
> test/jdk/java/awt/PrintJob/TestPrintNoException.java line 62:
>
>> 60: Frame testFrame = new Frame("print");
>> 61: try {
>> 62: if (tk != null) {
>
> `tk` can never be `null`.
ok
> test/jdk/java/awt/PrintJob/TestPrintNoException.java line 64:
>
>> 62: if (tk != null) {
>> 63: t.start();
>> 64: pj = tk.getPrintJob(testFrame, null, ja, null);
>
> The original test used Toolkit.getPrintJob with three parameters. Why does
> automated test need explicit attributes?
I wanted to be explicit..It is not needed ideally it seems...Removed
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/29874#discussion_r2893257114
PR Review Comment: https://git.openjdk.org/jdk/pull/29874#discussion_r2893256730
PR Review Comment: https://git.openjdk.org/jdk/pull/29874#discussion_r2893256342
