On Fri, 6 Mar 2026 03:17:21 GMT, Prasanta Sadhukhan <[email protected]> 
wrote:

>> Remove AppContext from JOptionPane. No tests fail with this change.
>
> src/java.desktop/share/classes/javax/swing/JOptionPane.java line 1659:
> 
>> 1657:     }
>> 1658: 
>> 1659:     private static volatile Frame sharedRootFrame;
> 
> Any reason for keeping it volatile? I guess similar change in other swing 
> classes for AppContext removal is not made volatile for ex. 
> https://github.com/openjdk/jdk/commit/0722ae926ff1327c47a922b1ca0b493a0d06526e

Being a little careful.

The one you reference is actually even more strict, not less, since it is used 
wrapped in synchronized {..}

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/30028#discussion_r2897125789

Reply via email to