On Wed, 11 Mar 2026 12:59:47 GMT, Daniel Gredler <[email protected]> wrote:

> There is a some unused code in SunGraphics2D which can be removed:
> 
> - The private static variable `slowTextTransformMask` is never used.
> - In `checkFontInfo`, the variable `txFontType` is never used.
> - The public static method `isRotated` is never used.
> - The commented out method `XcopyArea` is never used (and has been commented 
> out for 19+ years).
> - The method `transformBounds` is never used (it was used by `XcopyArea` but 
> was never deleted or commented out).
> 
> Additionally, there are quite a few `instanceof`s + casts which could benefit 
> from `instanceof` pattern matching.
> 
> (I've been spending some time in this area of the code figuring out some of 
> the remaining macOS printing issues, and these rough edges kept catching my 
> eye, so I figured it was better to spin them out into a small, independent 
> PR.)

LGTM too. But I'm running tests to be completely sure.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/30191#issuecomment-4041232930

Reply via email to